-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/129 reconcile on secondary ressource change #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/129 reconcile on secondary ressource change #130
Conversation
… into feature/129-reconcile-on-secondary-ressource-change- # Conflicts: # pkg/adapter/reconciler/blueprint_controller.go # pkg/adapter/reconciler/blueprint_controller_test.go
…external reconciles
… into feature/129-reconcile-on-secondary-ressource-change- # Conflicts: # pkg/adapter/reconciler/blueprint_controller.go # pkg/adapter/reconciler/blueprint_controller_test.go
…we want to reconcile
… into feature/129-reconcile-on-secondary-ressource-change- # Conflicts: # pkg/adapter/reconciler/blueprint_controller.go
… into feature/129-reconcile-on-secondary-ressource-change- # Conflicts: # pkg/adapter/reconciler/blueprint_controller.go # pkg/adapter/reconciler/blueprint_controller_test.go
… into feature/129-reconcile-on-secondary-ressource-change-
… into feature/129-reconcile-on-secondary-ressource-change-
… into feature/129-reconcile-on-secondary-ressource-change-
… into feature/129-reconcile-on-secondary-ressource-change-
…source-change- # Conflicts: # pkg/adapter/kubernetes/blueprintcr/v2/blueprintSpecCRRepository.go # pkg/adapter/kubernetes/blueprintcr/v2/blueprintSpecCRRepository_test.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. The two suggestions only have impact to the code quality.
We still need to test this in the cluster.
This is to catch changes to SecretRefs that are managed by the CES-Admin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested in cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Cluster tests were successful!
Thanks to @jelemux for your help with the tests!
Resolves #129