Skip to content

Conversation

@meiserloh
Copy link
Contributor

Resolves #129

… into feature/129-reconcile-on-secondary-ressource-change-

# Conflicts:
#	pkg/adapter/reconciler/blueprint_controller.go
#	pkg/adapter/reconciler/blueprint_controller_test.go
… into feature/129-reconcile-on-secondary-ressource-change-

# Conflicts:
#	pkg/adapter/reconciler/blueprint_controller.go
#	pkg/adapter/reconciler/blueprint_controller_test.go
… into feature/129-reconcile-on-secondary-ressource-change-

# Conflicts:
#	pkg/adapter/reconciler/blueprint_controller.go
… into feature/129-reconcile-on-secondary-ressource-change-

# Conflicts:
#	pkg/adapter/reconciler/blueprint_controller.go
#	pkg/adapter/reconciler/blueprint_controller_test.go
… into feature/129-reconcile-on-secondary-ressource-change-
… into feature/129-reconcile-on-secondary-ressource-change-
… into feature/129-reconcile-on-secondary-ressource-change-
… into feature/129-reconcile-on-secondary-ressource-change-
@alexander-dammeier alexander-dammeier changed the base branch from feature/121.3-remove-components to v2/develop October 17, 2025 08:40
…source-change-

# Conflicts:
#	pkg/adapter/kubernetes/blueprintcr/v2/blueprintSpecCRRepository.go
#	pkg/adapter/kubernetes/blueprintcr/v2/blueprintSpecCRRepository_test.go
Copy link
Contributor

@alexander-dammeier alexander-dammeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. The two suggestions only have impact to the code quality.
We still need to test this in the cluster.

Copy link
Contributor

@jelemux jelemux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested in cluster

Copy link
Contributor

@alexander-dammeier alexander-dammeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cluster tests were successful!
Thanks to @jelemux for your help with the tests!

@alexander-dammeier alexander-dammeier merged commit 38d049e into v2/develop Oct 22, 2025
1 check passed
@alexander-dammeier alexander-dammeier deleted the feature/129-reconcile-on-secondary-ressource-change- branch October 22, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants